Skip to content

Conversation

@addaleax
Copy link
Collaborator

@addaleax addaleax commented Nov 3, 2025

While Foliage has closed these tickets, these failures still occur from time to time in our CI, including the latest nightly.

Splitting these tests into multiple items seems like a reasonable way to avoid timeouts without losing test coverage.

…-2919

While Foliage has closed these tickets, these failures still
occur from time to time in our CI, including the latest nightly.

Splitting these tests into multiple items seems like a reasonable
way to avoid timeouts without losing test coverage.
Copilot AI review requested due to automatic review settings November 3, 2025 14:08
@addaleax addaleax requested a review from a team as a code owner November 3, 2025 14:08
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses test flakiness in the CLI REPL test suite by splitting parameterized tests into individual test cases. Instead of having single test cases that iterate through multiple versions, each version combination now gets its own test case with descriptive names.

Key changes:

  • Split GLIBC version deprecation warning test into separate test cases
  • Split OpenSSL version deprecation warning test into separate test cases

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@addaleax addaleax merged commit 1153fa8 into main Nov 3, 2025
152 of 155 checks passed
@addaleax addaleax deleted the 2918-2919-dev branch November 3, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants